Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing dependencies to requirements.txt #2127

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

lucas-wilkins
Copy link
Contributor

Resolves recent issue #2126

@lucas-wilkins lucas-wilkins linked an issue Jul 22, 2022 that may be closed by this pull request
@butlerpd
Copy link
Member

I think we should add @wpotrzebowski to the review since he was the one last working on fine tuning requirements.txt. Just in case there was something special we are missing here?

@lucas-wilkins
Copy link
Contributor Author

I think we should add @wpotrzebowski to the review since he was the one last working on fine tuning requirements.txt. Just in case there was something special we are missing here?

I meant to.

@lucas-wilkins
Copy link
Contributor Author

@wpotrzebowski I've removed the OS dependency - can you check I used the right versions (I picked the windows/linux associated ones)

Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "pyqt5-tools" if we already have PyQt5?

Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importlib_resources seems to refer to importlib-resources i.e. does it appear twice on the list?

@wpotrzebowski
Copy link
Contributor

Probablty not as a part of this pull request but it may be worth to set up GH actions that "tests" requirements.txt file when change is made in it. By testing I mean pip installing on workers.

@lucas-wilkins
Copy link
Contributor Author

importlib_resources seems to refer to importlib-resources i.e. does it appear twice on the list?

They're for different python versions - though as we discussed recently, there is no need to support python < 3.7, so the former is not really needed.

@lucas-wilkins
Copy link
Contributor Author

Probablty not as a part of this pull request but it may be worth to set up GH actions that "tests" requirements.txt file when change is made in it. By testing I mean pip installing on workers.

Could also set up tests to ensure that requirements.txt and the ymls are in sync

Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac. It works fine

@lucas-wilkins lucas-wilkins merged commit bc0dd55 into main Jul 27, 2022
@krzywon krzywon deleted the 2126-ui-compiler-not-found branch August 18, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI compiler not found
3 participants