Don't show RPA in the list of models #2022 #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butlerpd
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Very clean solution with only one line of code slightly modified. Tested with windows and works as intended. While it does show up in category manager as mentioned, it doesn't matter as adding the model to an existing category or even creating a new one does not allow it to showup due to this line of code.
Someone may want to double check on Mac OS but I recommend it be merged
butlerpd
added
the
Discuss At The Call
|
Tested on Mac - this works |
butlerpd
removed
the
Discuss At The Call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple conditional in the list comprehension for filling the model combobox with model names.
This can be easily removed once rpa works again.
Note: this only removes RPA from the model list on the fitting widget. It is still present in the Category Manager.