Enable model update on adding new plugin. #1597 #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing I got a key error which may be fixed by the keyerror fix in PR #2006. Once that is merged, I will merge release branch back into this and try again. |
butlerpd
approved these changes
Feb 5, 2022
There was a problem hiding this comment.
works like a charm ... even if I change the "name" attribute which currently makes the model no longer loadable (see issue #1443). In that case the model dropdown goes to its default model for the category and updates the fitpanel with the relevant parameters.
Code review is trivial so this can be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.