Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second attempt for easily accessible dependencies #1961
Second attempt for easily accessible dependencies #1961
Changes from all commits
215d409
4fbd2ff
e57f363
fd0e071
72c2822
882bc40
af0dce0
4a9e8b5
cf51d47
d7621db
e43dbbc
418e381
3a2a1b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
version
exists it might be a function or a module or a string. See my comment from before so I don't have to rewrite it. Or just punt and say that anything that isn't__version__
is a special case and address them as they appear.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above re: exception handling.
And to repeat, this will probably not do what you want.
Example
Though in this case
h5py.__version__
exists so you won't get here.If you insist on keeping this clause at least check
if isinstance(package.version, str)
.