-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q-Range slider fix for linear fits #1943
Conversation
humm... probably that slackard @butlerpd approving without really testing properly. I'll have a word with him about disciplined and professional 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue both for linear fits and for closing the charts.
The code is OK.
Thanks @krzywon! I will test on Mac |
ready for testing on OSX |
ready for testing on Win |
ready for testing on OSX |
The qrange bug is indeed fixed. I am not sure if range on the Linear Scale works correctly though. First of all it doesn't seem to be editable (or I don't know how to activate it) and secondly as soon as I start changing values in the log range, linear range gives strange values (outside q range). |
@wpotrzebowski, a lot of what you're seeing is documented in #1415, but please add more there if what you're seeing is different. I don't plan to go beyond fixing the error thrown in this PR. |
Can this be merged, please? |
ready for testing on OSX |
This fixes the issue noted in slack regarding an error when running a linear fit. This same error was also thrown when closing any plot with q-range sliders.
The signal used to link the GUI input to the sliders was changed from
textChanged
toeditingFinished
, but the disconnection was not changed to match.