Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding h5py=3.1 as a pip package #1880

Merged
merged 2 commits into from
Jul 3, 2021
Merged

Adding h5py=3.1 as a pip package #1880

merged 2 commits into from
Jul 3, 2021

Conversation

wpotrzebowski
Copy link
Contributor

Since conda package is conflicting and cannot be resolved I am trying with pip installable package

@wpotrzebowski
Copy link
Contributor Author

ready for testing on Linux

@wpotrzebowski
Copy link
Contributor Author

ready for testing on Windows

@wpotrzebowski
Copy link
Contributor Author

ready for testing on Win

@wpotrzebowski wpotrzebowski requested review from krzywon and rozyczko July 1, 2021 07:56
@wpotrzebowski
Copy link
Contributor Author

wpotrzebowski commented Jul 1, 2021 •
edited
Loading

Tested with PR builders and seems to build but I am not sure if this is the way to go?

@wpotrzebowski wpotrzebowski changed the title TST: adding h5py as a pip package Adding h5py=3.1 as a pip package Jul 1, 2021
rozyczko
rozyczko approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@krzywon
Copy link
Contributor

krzywon commented Jul 2, 2021

The PR builds succeed, which is good, but the installed Windows version is still showing the No module named 'sas.sascalc.dataloader.readers.cansas_reader_HDF5' error. I'm going to try using a slightly older version of h5py to see if we can fix both issues in one.

@krzywon krzywon mentioned this pull request Jul 2, 2021
Closed
@wpotrzebowski wpotrzebowski merged commit 0e3ff38 into main Jul 3, 2021
@wpotrzebowski wpotrzebowski deleted the h5py_dep branch July 3, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozyczko rozyczko rozyczko approved these changes

@krzywon krzywon krzywon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpotrzebowski @krzywon @rozyczko