Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing "alpha_dream" parameter in FittingOptions #1867

Closed
wpotrzebowski opened this issue Jun 3, 2021 · 4 comments · Fixed by #1873
Closed

Missing "alpha_dream" parameter in FittingOptions #1867

wpotrzebowski opened this issue Jun 3, 2021 · 4 comments · Fixed by #1873
Labels
Critical High priority Defect Bug or undesirable behaviour
Milestone
SasView 5.0.5

Comments

@wpotrzebowski
Copy link
Contributor

wpotrzebowski commented Jun 3, 2021 •
edited
Loading

16:33:32 - ERROR: Traceback (most recent call last):
File "site-packages/sasview-5.0.4-py3.6.egg/sas/qtgui/Perspectives/Fitting/FittingOptions.py", line 149, in onAlgorithmChange
File "site-packages/sasview-5.0.4-py3.6.egg/sas/qtgui/Perspectives/Fitting/FittingOptions.py", line 260, in updateWidgetFromBumps
File "", line 1, in
AttributeError: 'FittingOptions' object has no attribute 'alpha_dream'

It may be related but "Steps" parameter is missing from the interface (see attached screen shot). I think it used to set to 0?

Screenshot 2021-06-03 at 16 33 53
@wpotrzebowski wpotrzebowski changed the title Problem with "alpha_dream" parameter Missing "alpha_dream" parameter in FittingOptions Jun 3, 2021
@smk78
Copy link
Contributor

smk78 commented Jun 3, 2021

DREAM is working fine in 5.0.4 for me (W10/x64). My Fit Algorithms box looks like this:
image

@wpotrzebowski
Copy link
Contributor Author

Indeed, it is a Mac and I think Linux issue

@butlerpd butlerpd added Critical High priority Defect Bug or undesirable behaviour labels Jun 5, 2021
@butlerpd butlerpd added this to the SasView 5.0.5 milestone Jun 5, 2021
@rozyczko
Copy link
Member

Reproduced the issue on Linux.
Windows is OK, as @smk78 noticed.

rozyczko pushed a commit that referenced this issue Jun 18, 2021
Added a check for bumps-returned optimizer parameters against availab…
e655e0c 
…le UI fields.

Fixes #1867
@rozyczko
Copy link
Member

Seems ordering of the options mattered but also, we needed a check for new parameters, if they can be displayed in the UI.
Alpha wasn't there before so there is no UI element for it.

The ideal situation is to construct the UI dynamically depending on all the exposed parameters, this here is merely a bug fix.

@rozyczko rozyczko mentioned this issue Jun 18, 2021
Merged
wpotrzebowski pushed a commit that referenced this issue Jul 6, 2021
Merge pull request #1873 from SasView/bumps_option_display
adf1930 
Optimizer parameters checked against UI fields #1867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Critical High priority Defect Bug or undesirable behaviour
Projects
None yet
Milestone
SasView 5.0.5
Development

Successfully merging a pull request may close this issue.

Optimizer parameters checked against UI fields #1867 SasView/sasview
4 participants
@wpotrzebowski @rozyczko @smk78 @butlerpd