Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling Save Project dialog throws #1551

Closed
rozyczko opened this issue May 27, 2020 · 6 comments · Fixed by #2014
Closed

Cancelling Save Project dialog throws #1551

rozyczko opened this issue May 27, 2020 · 6 comments · Fixed by #2014
Labels
Defect Bug or undesirable behaviour Good First Issue Issues that are appropriate for newbies Minor Small job
Milestone
SasView 5.0.5

Comments

@rozyczko
Copy link
Member

A simple case of missing early return on cancelling the Save Project dialog.
Exception is caught and displayed and no other effects are present, just looks bad in the Log Explorer.
@rozyczko rozyczko added Defect Bug or undesirable behaviour Minor Small job labels May 27, 2020
@rozyczko rozyczko added this to the SasView 5.0.3 milestone May 27, 2020
@rozyczko
Copy link
Member Author

Similarly, Edit/Save Params to File dialog upon cancelling

@rozyczko rozyczko added the Good First Issue Issues that are appropriate for newbies label Jun 11, 2020
@rozyczko rozyczko modified the milestones: SasView 5.0.3, SasView 5.0.4 Jun 18, 2020
@krzywon
Copy link
Contributor

krzywon commented Jan 18, 2022

I think I fixed this issue in #1775 with commit a1596b1

@butlerpd
Copy link
Member

butlerpd commented Feb 1, 2022

@krzywon and @rozyczko. My test suggests that the first issue (save project) is fixed but that the second one " Edit>Save Params to File" Still has the issue. Let me know if I'm wrong and thi should be closed. Meanwhile I will move it to 5.1. If I am correct should this be labeled a good first issue? or is it more complicated?

@butlerpd butlerpd modified the milestones: SasView 5.0.5, SasView 5.1.0 Feb 1, 2022
@rozyczko
Copy link
Member Author

rozyczko commented Feb 1, 2022

You are right, @butlerpd - it has not been fixed for this action (Save Params to File). Considering this involves just looking up the error handling from "Save Params" and copy/pasting it, I would conider it a great first issue bug. Assuming we want to postpone it to the next release, rather than fix on the spot?

@butlerpd butlerpd modified the milestones: SasView 5.1.0, SasView 5.0.5 Feb 1, 2022
@butlerpd
Copy link
Member

butlerpd commented Feb 1, 2022

Ok .. moving it back to 5.0.5 and we can discuss whether to fix "on the spot" or not.

rozyczko added a commit that referenced this issue Feb 1, 2022
@rozyczko
Added a simple check so cancelling the dialog doesn't throw. #1551
f485cab
@butlerpd butlerpd linked a pull request Feb 1, 2022 that will close this issue
Added a simple check so cancelling the dialog doesn't throw. #1551 #2014
Merged
butlerpd added a commit that referenced this issue Feb 4, 2022
@butlerpd
Merge pull request #2014 from SasView/saveproject_cancel_fix_1551
5a90113 
Added a simple check so cancelling the dialog doesn't throw. #1551
@butlerpd
Copy link
Member

butlerpd commented Feb 4, 2022

The merge should have closed this but it didn't :-( so closing now

@butlerpd butlerpd closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect Bug or undesirable behaviour Good First Issue Issues that are appropriate for newbies Minor Small job
Projects
None yet
Milestone
SasView 5.0.5
Development

Successfully merging a pull request may close this issue.

Added a simple check so cancelling the dialog doesn't throw. #1551 SasView/sasview
3 participants
@rozyczko @krzywon @butlerpd