Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slicer in 5.0 doesn't contain the batch, fitting, log/linear etc features #1381

Closed
wpotrzebowski opened this issue Sep 2, 2019 · 0 comments · Fixed by #1721
Closed

Slicer in 5.0 doesn't contain the batch, fitting, log/linear etc features #1381

wpotrzebowski opened this issue Sep 2, 2019 · 0 comments · Fixed by #1721
Assignees
@rozyczko
Labels
Slicers Concerns slicer functionality
Milestone
SasView 5.0.4

Comments

@wpotrzebowski
Copy link
Contributor

Slicer in 5.0 doesn't contain the batch, fitting, log/linear etc features the batch, fitting, log/linear etc features added at code camp VI held in Grenoble in April 2017.

This is a follow-up on issue #1350, which partially has been fixed and merged in #1371.
@rozyczko rozyczko self-assigned this Sep 2, 2019
@rozyczko rozyczko added this to the SasView 5.1.0 milestone Sep 2, 2019
@murphyryanp murphyryanp mentioned this issue May 28, 2020
Closed
murphyryanp added a commit that referenced this issue May 28, 2020
@murphyryanp
Updating annulus slicer, batch slicing, and slicer parameters
b895714 
Changes to the annulus slicer and other slicers were merged from @rozyczko 'ESS_GUI_1381_slicer' regarding #1554 and #1381. The annulus slicer now opens and responds to changes in the SlicerParameters window. The batch slicing tab works, but the checkbox "Auto save generated 1D plots" does not save any files after clicking apply, and the fitting options dropdown is empty.
@wpotrzebowski wpotrzebowski added the Slicers Concerns slicer functionality label Jan 13, 2021
@butlerpd butlerpd modified the milestones: SasView 5.1.0, SasView 5.0.4 Jan 14, 2021
@butlerpd butlerpd linked a pull request Jan 14, 2021 that will close this issue
ESS_GUI 1381 slicer #1721
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozyczko rozyczko

Labels
Slicers Concerns slicer functionality
Projects
None yet
Milestone
SasView 5.0.4
Development

Successfully merging a pull request may close this issue.

ESS_GUI 1381 slicer SasView/sasview
3 participants
@wpotrzebowski @rozyczko @butlerpd