-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More informative error message when sasview is not on the python path #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I've also wondered whether this are sufficent instructions for users but I agree we need to keep it brief and add more detailed instructions in sasmodels API (may be there already).
@lucas-wilkins will come up with better suggestion for handling error |
It is not worth any extraordinary efforts. Once the data readers are available as a separate package the issue can be addressed properly. |
No extraordinary change made |
or at least there's not now ;) |
Some preferences:
Or perhaps change all of them to
and in my site-packages directory:
SasView uses a mixture of |
It looks like I've decided that the matrix multiplication operator |
e, pe, and v are probably equivalent in the sense that they are the lower case initials of the exception class. I would usually use e, or maybe ex. It's just a very unusual thing to catch. Personally, I would think the overlap between users that know what "Data loader" means, and those that wouldn't prefer a more specific error message, would be small. Roll it back if you like. |
These are minor preferences. I'll leave it to someone else to decide if they want to rollback or merge as is. Regardless, we should revisit this when the data loaders are available as a separate package. |
My commits were just a suggestion, I'm happy either way too. |
The import error now says that sasview/src is missing from the python path rather than module sas not found. This is still somewhat cryptic. The full instructions should say that sasview can be downloaded with "git clone https://github.com/sasview/sasview.git" but that is a bit much for an exception text string.
See #467.