Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: Update queries and db structure to lastest TrinityCore cha… #22

Closed
wants to merge 2 commits into from

Conversation

Carbenium
Copy link
Contributor

@Sarjuuk
Copy link
Owner

Sarjuuk commented Jun 28, 2015

Thanks for the heads up.
I'm currently combing through the changes as there are some changes, that are unnecessary or affect code, that wasn't also updated.

I'll edit them in later.

/e: barely any of the structure changes to aowow_quests are referenced in php.
Are you sure these changes were intentional?

@@ -278,7 +278,7 @@ protected function generateContent()
{
$this->addJS('?data=zones&locale='.User::$localeId.'&t='.$_SESSION['dataKey']);

$trainer = new CreatureList(array(CFG_SQL_LIMIT_NONE, ['ct.id', $list], ['s.guid', NULL, '!'], ['ct.npcflag', 0x10, '&']));
$trainer = new CreatureList(array(CFG_SQL_LIMIT_NONE, ['ct.ID', $list], ['s.guid', NULL, '!'], ['ct.npcflag', 0x10, '&']));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aowow_creature did not change.

zealous find 'n replace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, right. That got mixed up. I thoght on the first sight it was referencing npc_trainer...

@Carbenium Carbenium changed the title fixup! DB: Update queries and db structure to lastest TrinityCore cha… DB: Update queries and db structure to lastest TrinityCore cha… Jun 28, 2015
@Sarjuuk
Copy link
Owner

Sarjuuk commented Jun 29, 2015

TrinityCore/TrinityCore#14941
bloody hell!
better to wait this one out and add both at once

@Carbenium
Copy link
Contributor Author

Yeah. You're right. I totally forgot about that one. It should be merged soon.

@Carbenium
Copy link
Contributor Author

TC merge done TrinityCore/TrinityCore@adb5d3e
Let's start the work :D

@Sarjuuk
Copy link
Owner

Sarjuuk commented Jun 29, 2015

The impact is actually only minor. I didn't even use these fields directly, although they are copied over.
They are just used on setup to categorize more GOs as quest-related.

I think it's best to drop them altogether.

@Carbenium
Copy link
Contributor Author

More changes coming: TrinityCore/TrinityCore#14982

@FrancescoBorzi
Copy link

You are going to hate me, aren't you? :D

@Sarjuuk
Copy link
Owner

Sarjuuk commented Jul 1, 2015

i already do, i already do...

;P

@Sarjuuk
Copy link
Owner

Sarjuuk commented Jul 2, 2015

@ShinDarth are .. you done

careful optimism

@FrancescoBorzi
Copy link

I don't know, maybe other changes can be backported. I need to discuss with the others:

https://gist.github.com/ShinDarth/20a32dd47cfbc37cab43

@Sarjuuk Sarjuuk force-pushed the master branch 3 times, most recently from 20d3d5e to 4a47900 Compare July 5, 2015 23:08
@Carbenium
Copy link
Contributor Author

@Sarjuuk : how is it going with the changes?

@Sarjuuk
Copy link
Owner

Sarjuuk commented Jul 10, 2015

Have yet to touch it again.
Probably on Sunday.

@Sarjuuk
Copy link
Owner

Sarjuuk commented Jul 19, 2015

well ... it is sunday!

changes made in 5b8a862

@Sarjuuk Sarjuuk closed this Jul 19, 2015
@Carbenium Carbenium deleted the renames branch March 20, 2022 21:49
Helias added a commit to wowgaming/aowow that referenced this pull request Jan 6, 2023
* feat: check lowercase soundfile path too, fix spell formula calculation

* doc: update troubleshooting

* doc: update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants