-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB: Update queries and db structure to lastest TrinityCore cha… #22
Conversation
Thanks for the heads up. I'll edit them in later. /e: barely any of the structure changes to aowow_quests are referenced in php. |
@@ -278,7 +278,7 @@ protected function generateContent() | |||
{ | |||
$this->addJS('?data=zones&locale='.User::$localeId.'&t='.$_SESSION['dataKey']); | |||
|
|||
$trainer = new CreatureList(array(CFG_SQL_LIMIT_NONE, ['ct.id', $list], ['s.guid', NULL, '!'], ['ct.npcflag', 0x10, '&'])); | |||
$trainer = new CreatureList(array(CFG_SQL_LIMIT_NONE, ['ct.ID', $list], ['s.guid', NULL, '!'], ['ct.npcflag', 0x10, '&'])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aowow_creature did not change.
zealous find 'n replace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, right. That got mixed up. I thoght on the first sight it was referencing npc_trainer...
TrinityCore/TrinityCore#14941 |
Yeah. You're right. I totally forgot about that one. It should be merged soon. |
TC merge done TrinityCore/TrinityCore@adb5d3e |
The impact is actually only minor. I didn't even use these fields directly, although they are copied over. I think it's best to drop them altogether. |
More changes coming: TrinityCore/TrinityCore#14982 |
You are going to hate me, aren't you? :D |
i already do, i already do... ;P |
@ShinDarth are .. you done careful optimism |
I don't know, maybe other changes can be backported. I need to discuss with the others: https://gist.github.com/ShinDarth/20a32dd47cfbc37cab43 |
20d3d5e
to
4a47900
Compare
@Sarjuuk : how is it going with the changes? |
Have yet to touch it again. |
well ... it is sunday! changes made in 5b8a862 |
* feat: check lowercase soundfile path too, fix spell formula calculation * doc: update troubleshooting * doc: update README
…nges (TrinityCore/TrinityCore@6b43e72)