Fix for Issue #7 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurensvanrun
pushed a commit
to mendrix/SonarDelphi
that referenced
this pull request
Mar 10, 2021
…prefix is uncommon here. Issue SandroLuck#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for the issue #7 I reported earlier.
I have overseen that my IDE's config deletes all unnecessary white-spaces automatically. Sorry. (I am using Beyond Comapre as diff- and merge-tool and with Beyond Compare one can disable the showing of not important changes. So did I.)
The mere fix is in the antler-grammar-file "Delphi.g" at lines 251 and 256.
There are some new tests in the file "GrammarTestNew.pas", of course.
The both files "DelphiLexer.java" and "DelphiParser.java" are generated automatically by Antlr3 and therefore not possible to diff :)