Simple math classes (improvements needed) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samyssmile
requested changes
Oct 25, 2023
| package de.edux.math; | ||
|
|
||
| /** | ||
| * @author ImGolem? |
| package de.edux.math; | ||
|
|
||
| /** | ||
| * @author ImGolem? |
| */ | ||
| public final class Validations { | ||
|
|
||
| public static void size(double[] f, double[] s) { |
There was a problem hiding this comment.
write what is f and s dont use shortnames
| import java.util.NoSuchElementException; | ||
|
|
||
| /** | ||
| * @author ImGolem? |
| public class Matrix implements Entity<Matrix>, Iterable<Double> { | ||
|
|
||
| /** | ||
| * Represents a raw matrix as a default two-dimension array |
There was a problem hiding this comment.
remove comment, we dont use java docs on private fields
| public class Vector implements Entity<Vector>, Iterable<Double> { | ||
|
|
||
| /** | ||
| * Represents a raw vector as a default array |
| } | ||
|
|
||
| /** | ||
| * @return raw vector (array) |
| } | ||
|
|
||
| /** | ||
| * @return length of the vector |
| @@ -0,0 +1,13 @@ | |||
| package de.edux.math; | |||
|
|
|||
| public interface EntityTest { | |||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| public class MatrixTest implements EntityTest { |
Samyssmile
requested changes
Oct 25, 2023
|
|
||
| @Override | ||
| @Test | ||
| public void testMultiply() { |
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| public class VectorTest implements EntityTest { |
There was a problem hiding this comment.
Do not use interface in a test class
Samyssmile
requested changes
Oct 25, 2023
| /** | ||
| * @author ImGolem? | ||
| */ | ||
| public interface Entity<T> { |
There was a problem hiding this comment.
Possible to find better Name for this Interface?
Samyssmile
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12