Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Sass Builder NuGet package to AspNetCore.SassCompiler #92

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Change Sass Builder NuGet package to AspNetCore.SassCompiler #92

merged 1 commit into from
Jun 1, 2022

Conversation

CalebABG
Copy link
Contributor

@CalebABG CalebABG commented Jun 1, 2022

This provides a working solution for Apple Silicon machines to build the Web project.

The previous NuGet package: LibSassBuilder has an open issue for support of M1 Macs running into issues with the MSBuild Target complaining about not being able to run the command to compile the Sass files - johan-v-r/LibSassBuilder#42

Not quite sure if the compilerconfig.json files are still needed, so I left them as is.

Copy link
Owner

@SakuraIsayeki SakuraIsayeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I never approve a library change on PR, unless there's good reasons to match. Here it's the sheer deprecation of the LibSassCompiler that just ticks the box, no questions asked. Just about anything will perform better than this, provided the same conditions of course.

Also yep, you can remove the compilerconfig.json, as it's a vestige of the time where WOWS Karma used Webcompiler as its SASS/SCSS compiler ;)

@SakuraIsayeki SakuraIsayeki merged commit a81947f into SakuraIsayeki:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants