Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prop codemod - FE-3330 #41

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

DipperTheDan
Copy link
Contributor

@DipperTheDan DipperTheDan commented Jan 19, 2021

Proposed behaviour

Create a new codemod that is able to add a new prop and value to a specified component.

Current behaviour

Such a codemod does not exist.

Checklist

  • Release notes (Conventional Commits)
  • Unit tests
  • Readme updated

Additional context

Link to codesandbox where code can be downloaded as a zip and ran locally.
https://codesandbox.io/s/elegant-agnesi-vqhlm?file=/src/index.js

Testing instructions

Run codemod over a local repository.

Copy link
Contributor

@samtjo samtjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mate, just a few comments from me then I'll approve 👍🏻

edleeks87
edleeks87 previously approved these changes Jan 21, 2021
samtjo
samtjo previously approved these changes Jan 21, 2021
KatarzynaQA
KatarzynaQA previously approved these changes Jan 25, 2021
@DipperTheDan DipperTheDan dismissed stale reviews from KatarzynaQA, samtjo, and edleeks87 via 1706a21 January 25, 2021 15:56
@DipperTheDan DipperTheDan force-pushed the button_margin_codemod branch from 8b182c8 to 1706a21 Compare January 25, 2021 15:56
@DipperTheDan DipperTheDan merged commit 3c6aaa6 into master Jan 26, 2021
@DipperTheDan DipperTheDan deleted the button_margin_codemod branch January 26, 2021 09:20
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants