Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYNR-1279 #5

Merged
merged 4 commits into from
Apr 24, 2018
Merged

SYNR-1279 #5

merged 4 commits into from
Apr 24, 2018

Conversation

kimyen
Copy link
Contributor

@kimyen kimyen commented Apr 18, 2018

No description provided.

README.Rmd Outdated

The example below copy File ID `syn123` to Project ID `syn456`:
```{r eval=F}
copy("syn123", "syn456")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's some extra space here and in a couple other code chunks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karawoo! Do you refer to the spaces before copy or the spaces between the parameters?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space before copy. I like the space between the parameters.

README.Rmd Outdated
copy("syn123", "syn456")
```

The first parameter in `copy()` can be a File ID, a Table ID, or a Link ID. The second parameter must be a Folder ID or a Project ID.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that copying a folder also works. The documentation for copy() doesn't state what types of entities can be copied; can we put this information there as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this topic, the copy function in the Python client is not tested. I want to hold off on advertising copying folder (and possibly recursively copy the entire hierarchy) until we refactor and have all test coverage for this function. This refactor would also include the re-write/ edit the copy function documentation in Python. synapserutils will then inherit the new docs. I will update this part then.

README.Rmd Outdated

#### Copy Entity (File, Folder, Table, Link, and Project)

The example below copy File ID `syn123` to Project ID `syn456`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copies

README.Rmd Outdated

# synapserutils

The `synapserutils` package provides a set of utility functions, built on top of [`synapser`](http://sage-bionetworks.github.io/synapser/) package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built on top of the synapser package

README.Rmd Outdated

#### Copy Wiki and Wiki Subpage

To copy a wiki page that associate with an Entity (Project/ File/ Folder/ Table) `syn123` to another Entity `syn789`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is associated with

README.Rmd Outdated
syncToSynapse("/path/to/manifest.tsv")
```

The manifest file format and instructions on how to create one could be found [here](http://docs.synapse.org/articles/uploading_in_bulk.html#creating-a-manifest) and by:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be found here

@brucehoff
Copy link
Member

Looks good!

@brucehoff brucehoff merged commit 94cadd5 into Sage-Bionetworks:develop Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants