Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNR-1511] add missing sync and monitor functions #24

Merged
merged 4 commits into from
Sep 23, 2023
Merged

[SYNR-1511] add missing sync and monitor functions #24

merged 4 commits into from
Sep 23, 2023

Conversation

danlu1
Copy link
Contributor

@danlu1 danlu1 commented Sep 20, 2023

This PR contains changes to add missing sync and monitor functions: generate_sync_manifest, readManifestFile, and notifyMe.

@danlu1 danlu1 requested a review from thomasyu888 September 20, 2023 22:43
thomasyu888
thomasyu888 requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just one comment

@thomasyu888 thomasyu888 changed the title add missing sync and monitor functions [SYNR-1511] add missing sync and monitor functions Sep 23, 2023
@thomasyu888 thomasyu888 merged commit 53bb5ad into master Sep 23, 2023
@thomasyu888 thomasyu888 deleted the SYNR_1511_add_functions branch February 5, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danlu1 @thomasyu888