Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sabaki 50.1 Hangs when Loading Some SGF Files #663

Closed
MacErlang opened this issue Mar 18, 2020 · 3 comments
Closed

Sabaki 50.1 Hangs when Loading Some SGF Files #663

MacErlang opened this issue Mar 18, 2020 · 3 comments
Labels

Comments

@MacErlang
Copy link

Hello,

I am attaching four sgf files that I downloaded from the web. The current version of Sabaki hangs
when I tried to load any of these files. However, all of these files open just fine in Sabaki 35.1. There are other files with similar issues. Possible bugs?

Best,
Shun

Test Files.zip

@MacErlang
Copy link
Author

Extra spaces or empty lines in the file might have something to do with this issue.

@yishn yishn added the bug label Mar 18, 2020
@yishn yishn closed this as completed in 9b77a8d Mar 18, 2020
@yishn
Copy link
Member

yishn commented Mar 18, 2020

The hanging of the file 珍珑棋局-1200手 - Original.sgf is of particular interest here: We use recursive functions to process all the nodes in a game tree and for some reason we hit the maximum stack size with gametree.getHeight() even though the game tree "only" has 3603 moves with only one tiny variation. Furthermore, it seems the game tree object of that file is so big that JSON.stringify() also hits the maximum stack size. This is now fixed.

yishn added a commit that referenced this issue Mar 18, 2020
yishn added a commit that referenced this issue Mar 18, 2020
@MacErlang
Copy link
Author

@yishn WOW, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants