-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jango Fett, Concealing the Conspiracy #537
Merged
AMMayberry1
merged 12 commits into
main
from
feature/jango-fett-concealing-the-conspiracy
Feb 13, 2025
Merged
Jango Fett, Concealing the Conspiracy #537
AMMayberry1
merged 12 commits into
main
from
feature/jango-fett-concealing-the-conspiracy
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMMayberry1
reviewed
Feb 6, 2025
server/game/cards/03_TWI/leaders/JangoFettConcealingTheConspiracy.ts
Outdated
Show resolved
Hide resolved
server/game/cards/03_TWI/leaders/JangoFettConcealingTheConspiracy.ts
Outdated
Show resolved
Hide resolved
server/game/cards/03_TWI/leaders/JangoFettConcealingTheConspiracy.ts
Outdated
Show resolved
Hide resolved
test/server/cards/03_TWI/leaders/JangoFettConcealingTheConspiracy.spec.ts
Show resolved
Hide resolved
test/server/cards/03_TWI/leaders/JangoFettConcealingTheConspiracy.spec.ts
Outdated
Show resolved
Hide resolved
test/server/cards/03_TWI/leaders/JangoFettConcealingTheConspiracy.spec.ts
Show resolved
Hide resolved
AMMayberry1
reviewed
Feb 7, 2025
server/game/cards/03_TWI/leaders/JangoFettConcealingTheConspiracy.ts
Outdated
Show resolved
Hide resolved
AMMayberry1
reviewed
Feb 13, 2025
AMMayberry1
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Notes
The work for implementing this leader uncovered an issue with the
DistributeDamageSystem
. Essentially, this system had no way to identify the source of the damage if it was different from the card that triggered the ability. The only current example is Overwhelming Barrage, where the event has the ability, but a unit deals the distributed damage. I addressed this by adding asource
property toIDistributeDamageSystemProperties
. I'm open to feedback on how I implemented this!Test Cases
Undeployed
Deployed
Extra
Bounty.spec.ts
, ensuring damage dealt by collecting a bounty is attributed to the correct unit (including a stolen unit with a bounty)