Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jango Fett, Concealing the Conspiracy #537

Merged
merged 12 commits into from
Feb 13, 2025

Conversation

moyerr
Copy link
Collaborator

@moyerr moyerr commented Feb 6, 2025

Undeployed Deployed

Developer Notes

The work for implementing this leader uncovered an issue with the DistributeDamageSystem. Essentially, this system had no way to identify the source of the damage if it was different from the card that triggered the ability. The only current example is Overwhelming Barrage, where the event has the ability, but a unit deals the distributed damage. I addressed this by adding a source property to IDistributeDamageSystemProperties. I'm open to feedback on how I implemented this!

Test Cases

Undeployed

  1. Trigger ability when a friendly unit deals combat damage
  2. Trigger ability when a friendly unit deals damage from its own ability (e.g. Elite P-38)
  3. Trigger ability when a friendly unit deals direct damage from an event (Strike True)
  4. Trigger ability when a friendly unit deals distributed damage from an event (Overwhelming Barrage)
  5. Trigger ability when a friendly unit deals damage from an ability gained from an upgrade (Vambrace Flamethrower)
  6. Trigger ability when a friendly unit deals damage at the start of the regroup phase (Sneak Attack + Ruthless Raider)
  7. Trigger ability when a stolen unit deals combat damage to an enemy unit (Change of Heart)
  8. Don't trigger ability when damage is dealt directly from an event (Open Fire)
  9. Don't trigger ability when damage is dealt directly from an upgrade (Vader's Lightsabeer)
  10. Don't trigger ability when a friendly unit deals 0 damage in combat (Grogu)
  11. Don't trigger ability at the start of the regroup phase if Jango was exhausted in the previous action phase
  12. Don't trigger ability when a friendly unit deals damage to another friendly unit (Doctor Pershing)

Deployed

  1. Trigger ability when a friendly unit deals combat damage
  2. Trigger ability when a friendly unit deals damage from its own ability (e.g. Elite P-38)
  3. Trigger ability when a friendly unit deals direct damage from an event (Strike True)
  4. Trigger ability when a friendly unit deals distributed damage from an event (Overwhelming Barrage)
  5. Trigger ability when a friendly unit deals damage from an ability gained from an upgrade (Vambrace Flamethrower)
  6. Trigger ability when a stolen unit deals combat damage to an enemy unit (Change of Heart)
  7. Don't trigger ability when damage is dealt directly from an event (Open Fire)
  8. Don't trigger ability when damage is dealt directly from an upgrade (Vader's Lightsabeer)
  9. Don't trigger ability when a friendly unit deals 0 damage in combat (Grogu)
  10. Don't trigger ability when a friendly unit deals damage to another friendly unit (Doctor Pershing)

Extra

  • Added a test case to Hold-Out Blaster, ensuring the damage dealt when played triggers Jango's ability
  • Added a test case to Maul - Shadow Collective Visionary, ensuring that the deflected combat damage can still trigger an opposing Jango leader's ability
  • Added three test cases to Bounty.spec.ts, ensuring damage dealt by collecting a bounty is attributed to the correct unit (including a stolen unit with a bounty)

@moyerr moyerr marked this pull request as ready for review February 7, 2025 15:54
@AMMayberry1 AMMayberry1 mentioned this pull request Feb 7, 2025
@AMMayberry1 AMMayberry1 merged commit ffaecb9 into main Feb 13, 2025
2 checks passed
@AMMayberry1 AMMayberry1 deleted the feature/jango-fett-concealing-the-conspiracy branch February 13, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants