Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for box size corrections. #27

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Added support for box size corrections. #27

merged 2 commits into from
Jul 27, 2022

Conversation

bwvdnbro
Copy link
Member

To be combined with the same branch in the velociraptor-python and pipeline-configs repositories.

@bwvdnbro bwvdnbro requested a review from EvgeniiChaikin June 24, 2022 09:27
EvgeniiChaikin
EvgeniiChaikin reviewed Jun 26, 2022
View reviewed changes
Copy link
Collaborator

@EvgeniiChaikin EvgeniiChaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a prefix box_size_ for all new words that start with correction so that it is more clear what we are trying to correct?

@bwvdnbro bwvdnbro changed the title Draft: Added support for box size corrections. Added support for box size corrections. Jul 27, 2022
@bwvdnbro bwvdnbro self-assigned this Jul 27, 2022
@bwvdnbro bwvdnbro merged commit c224341 into master Jul 27, 2022
@bwvdnbro bwvdnbro deleted the box-size-correction branch July 27, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgeniiChaikin EvgeniiChaikin EvgeniiChaikin left review comments

Assignees

@bwvdnbro bwvdnbro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwvdnbro @EvgeniiChaikin