provision.sh: refactor while loops and fix packaging-related breakage #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
force-pushed
the
wip-278
branch
3 times, most recently
from
f66c9c0 to
9c1263e
Compare
|
This passed a |
smithfarm
force-pushed
the
wip-278
branch
6 times, most recently
from
c187bbc to
2117da2
Compare
|
Triggered RPM build of this PR's branch in https://build.opensuse.org/package/show/filesystems:ceph/sesdev and will run |
smithfarm
force-pushed
the
wip-278
branch
4 times, most recently
from
1841f51 to
3175a7a
Compare
If all the "/tmp/ready-{{ node.name }}" files don't get created in the
first iteration of the loop, the scp fails and that causes the whole
script to fail because it is running under "set -e".
(This while loop was written before we had "set -e" at the top of the
script.)
Since we're touching the code of the loop anyway, take this opportunity
to refactor it.
Fixes: c0d5df1
Fixes: SUSE#278
Signed-off-by: Nathan Cutler <[email protected]>
|
Tested manually. |
smithfarm
changed the title
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all the "/tmp/ready-{{ node.name }}" files don't get created in the
first iteration of the loop, the scp fails and that causes the whole
script to fail because it is running under "set -e".
(This while loop was written before we had "set -e" at the top of the
script.)
Since we're touching the code of the loop anyway, take this opportunity
to refactor it.
Fixes: c0d5df1
Fixes: #278
Signed-off-by: Nathan Cutler [email protected]