Allow newer versions of json-schema then 2.2.5 #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 25, 2019
thardeck
force-pushed
the
update_json_schema
branch
5 times, most recently
from
e669239 to
cddecc4
Compare
aduffeck
approved these changes
Jun 28, 2019
While the performance issue is still not completely fixed voxpupuli/json-schema#261 newer Ruby versions show warnings with the old json-schema versions so we need to support the newer ones. Newer json-schema versions have a littel different error messages that's why the tests needed to be adapted accordingly.
and still support the old versions for backward compatibility.
thardeck
force-pushed
the
update_json_schema
branch
from
cddecc4 to
7720075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the performance issue is still not completely fixed
voxpupuli/json-schema#261
newer Ruby versions show warnings with the old json-schema versions so
we need to support the newer ones.
Newer json-schema versions have a littel different error messages that's
why the tests needed to be adapted accordingly.