-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colocation and ordering for clvm #373
Conversation
Step 3 (point 2) had a command to add the resource to the DLM group, but I've moved it to the newly added step 4: [removed outdated image] |
bsc#1222440 jsc#DOCTEAM-1357
8fb3f09
to
148788f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only one nitpicking
xml/ha_cluster_lvm.xml
Outdated
<listitem> | ||
<para> | ||
For multiple VGs using either activation mode, you can add constraints | ||
that apply to batches of resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example in below looks like it's exclusive activation mode, given that vg1 and vg2 are not explicitly cloned here. How about being more clear, for example something like:
"For multiple VGs, you can add constraints that apply to batches of resource. For instance for exclusive activation mode:
..."
And after the example:
"For multiple VGs using shared activation mode, you can first clone vg1 and vg2, and add similar constraints that apply to the clone resources instead".
Just an idea, I believe there are other ways to clarify it :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you, I didn't catch that because the original procedure didn't have a step for cloning, but that's because it added the shared mode VG to the group, and the group is cloned. So of course without the group you have to clone. I'll add another dot point to address this.
[Updated after rethinking it a bit] Shared activated VG means it is active on all nodes; thus, same as for DLM, they should be part of IMO, there should be to unordered items - shared activation and exclusive one, plus an example for one VG and multiple VGs. BTW, I am not sure but isn't "batches of resources" what Pacemaker calls "resource sets"? @gao-yan ? |
agree.
I don't think I fully understand your sentence above. The resource set in "()" does indicate the constraints configuration for "sequential=false" and "require-all=true" internally.
Yes, more precisely the parentheses resource set in crmsh syntax ;) |
Good idea, I'll update it to do so.
Funnily enough, in hindsight I have no idea why I said "batches of resources" instead of just "multiple resources" 🤔 |
Ah, great, now, I understand Jiri's previous comments, thank you Thalia ! ps, My English should improve from this ;) |
Thanks, @tahliar . It looks even more clear now.
Yes, the terminology is "resource set". We demonstrated a type of resource set which implies sequential="true": In here it's a different type which basically has sequential=false as Roger pointed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Add colocation and ordering for clvm bsc#1222440 jsc#DOCTEAM-1357 * Apply tech review feedback * Restructure step 4
* Add colocation and ordering for clvm bsc#1222440 jsc#DOCTEAM-1357 * Apply tech review feedback * Restructure step 4
* Add colocation and ordering for clvm bsc#1222440 jsc#DOCTEAM-1357 * Apply tech review feedback * Restructure step 4
* Add colocation and ordering for clvm bsc#1222440 jsc#DOCTEAM-1357 * Apply tech review feedback * Restructure step 4
PR creator: Description
Added a step to make sure VGs are only activated after DLM is already running.
PR creator: Are there any relevant issues/feature requests?
PR creator: Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
main
, no backport necessary)PR reviewer only: Have all backports been applied?
The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.