Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vistatec/sle 15 sp5 locdrop2 sleha localisation checkin #342

Conversation

ptinley-vt
Copy link
Collaborator

@ptinley-vt ptinley-vt commented Jul 28, 2023

PR creator: Description

SLEHA

DC-SLE-HA-administration - ja-jp zh-cn zh-tw (3)
DC-SLE-HA-geo-clustering (Quick Start) - de-de es-es fr-fr it-it ja-jp pt-br zh-cn zh-tw (8)
DC-SLE-HA-installation - de-de es-es fr-fr it-it ja-jp pt-br zh-cn zh-tw (8)

19 books in total

PR creator: Are there any relevant issues/feature requests?

no

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE-HA 15
    • 15 SP5

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

@jfaltenbacher
Copy link
Contributor

Hi Patrick, thank you very much. I have processed all books and they look good. There is a small layout issue in the PDF versions of the zh-tw admin guide and ja-jp, zh-tw geo clustering quick start but we check on our end.

@ptinley-vt
Copy link
Collaborator Author

Thanks Julia.

Let me know what these layout issues are and I can check them out with the SLES/SLED component of locdrop 2.
Regards,
Patrick

@jfaltenbacher
Copy link
Contributor

jfaltenbacher commented Jul 31, 2023

Hi Patrick,
The main header of the books is overlapping for the zh-tw admin guide and ja-jp, zh-tw geo clustering quick start.
I have checked the files Valentina had uploaded to the ftp and the issue also appears there.

The zh-tw Geo clustering is the worse:

image

Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the layout issue, the rest looks good - I think we can go ahead and merge

@jfaltenbacher jfaltenbacher merged commit d93abb3 into maintenance/SLEHA15SP5 Aug 2, 2023
@jfaltenbacher jfaltenbacher deleted the vistatec/sle_15SP5_locdrop2_sleha_localisation-checkin branch August 8, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants