Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed directory from csync2 command for DRBD #258

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conversation

tahliar
Copy link
Collaborator

@tahliar tahliar commented Oct 11, 2022

Description

I've added -r to the csync2 -xv /etc/drbd.d/ command. In addition to the bug report requesting it, I also had better results using -r in my test cluster than I did without it, and I can't think of any potential drawbacks to adding it.

Reduced the command back to just csync2 -xv, as the DRBD files are included by default.

Backports

  • To maintenance/SLEHA15SP4
  • To maintenance/SLEHA15SP3
  • To maintenance/SLEHA15SP2
  • To maintenance/SLEHA15SP1
  • To maintenance/SLEHA15
  • To maintenance/SLEHA12SP5
  • To maintenance/SLEHA12SP4

References

jsc#DOCTEAM-735
bsc#1203168

jsc#DOCTEAM-735
bsc#1203168
@tahliar
Copy link
Collaborator Author

tahliar commented Oct 11, 2022

@gao-yan This step has a csync2 command, and then manual scp commands as alternatives:

image

However, the scp option also copies /etc/drbd.conf, which would not be copied by csync2 -xrv /etc/drbd.d/. So should the csync2 command actually be csync2 -xrv /etc/drbd*?

@tahliar tahliar changed the title Add -r to csync2 command for DRBD Removed directory from csync2 command for DRBD Oct 20, 2022
@tahliar
Copy link
Collaborator Author

tahliar commented Oct 20, 2022

I've reduced the command back to just csync2 -xv, but also left the alternative manual steps:

image

Copy link
Contributor

@gao-yan gao-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @tahliar

@tahliar tahliar merged commit 4c5c099 into main Oct 20, 2022
@tahliar tahliar deleted the DOCTEAM-735-csync-drbd branch October 20, 2022 08:01
tahliar added a commit that referenced this pull request Oct 20, 2022
* Add -r to csync2 command for DRBD

jsc#DOCTEAM-735
bsc#1203168

* Cut command back to just csync2 -xv
tahliar added a commit that referenced this pull request Oct 20, 2022
* Add -r to csync2 command for DRBD

jsc#DOCTEAM-735
bsc#1203168

* Cut command back to just csync2 -xv
tahliar added a commit that referenced this pull request Oct 20, 2022
* Add -r to csync2 command for DRBD

jsc#DOCTEAM-735
bsc#1203168

* Cut command back to just csync2 -xv
tahliar added a commit that referenced this pull request Oct 20, 2022
* Add -r to csync2 command for DRBD

jsc#DOCTEAM-735
bsc#1203168

* Cut command back to just csync2 -xv
tahliar added a commit that referenced this pull request Oct 20, 2022
* Add -r to csync2 command for DRBD

jsc#DOCTEAM-735
bsc#1203168

* Cut command back to just csync2 -xv
tahliar added a commit that referenced this pull request Oct 20, 2022
* Add -r to csync2 command for DRBD

jsc#DOCTEAM-735
bsc#1203168

* Cut command back to just csync2 -xv
tahliar added a commit that referenced this pull request Oct 20, 2022
* Add -r to csync2 command for DRBD

jsc#DOCTEAM-735
bsc#1203168

* Cut command back to just csync2 -xv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants