Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming gradient variable to prevent error as reported in #1200 #1202

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Renaming gradient variable to prevent error as reported in #1200 #1202

merged 1 commit into from
Jun 26, 2020

Conversation

khuck
Copy link
Contributor

@khuck khuck commented Jun 25, 2020

As suggested, renamed "gradient" variable to "grad" in order to avoid runtime error.

@khuck khuck requested a review from hkaiser June 25, 2020 21:38
@hkaiser hkaiser added this to the 0.0.1 milestone Jun 25, 2020
hkaiser
hkaiser approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@khuck khuck mentioned this pull request Jun 26, 2020
Open
@hkaiser hkaiser merged commit 835c007 into master Jun 26, 2020
@hkaiser hkaiser deleted the fixing_1200_again branch June 26, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: PhySL type: compatibility issue type: enhancement
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@khuck @hkaiser