Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cms code #81

Merged
merged 12 commits into from
Jul 16, 2020
Merged

Feature/cms code #81

merged 12 commits into from
Jul 16, 2020

Conversation

nionata
Copy link
Member

@nionata nionata commented Jul 14, 2020 •
edited
Loading

  • updated db dump make sure to rebuild
  • updated postman with new api routes and bodies

Closes #76

  • moved all logic, services, and routes from sessions to classrooms
  • stripped sessions down
  • modified on join create a new session

Closes #80

  • created teacher content type
  • created classroom manager service, route, and policy to handle both mentors and teachers
  • updates permissions policy

@nionata nionata requested a review from rennemannd July 14, 2020 23:22
@nionata
Copy link
Member Author

nionata commented Jul 14, 2020 •
edited
Loading

The backend portion has been implemented. The following client breaking changes need to be addressed

  • GET /sessions/code/:code -> GET /classrooms/join/:code
  • POST /sessions/join -> POST /classrooms/join/:code
  • GET /session/student/activities -> GET /activities (until we figure out the days / schedule)
  • GET /mentors/me -> GET /classroom-managers/me

@nionata nionata requested a review from tamargoadam July 15, 2020 14:48
tamargoadam
tamargoadam approved these changes Jul 16, 2020
View reviewed changes
Copy link

@tamargoadam tamargoadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Nice job! 👍

@nionata nionata merged commit 893e746 into develop Jul 16, 2020
@nionata nionata deleted the feature/cms-code branch July 16, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamargoadam tamargoadam tamargoadam approved these changes

@rennemannd rennemannd Awaiting requested review from rennemannd

Assignees

@nionata nionata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Classroom Manager Migrate Code from Sessions to Classrooms
3 participants
@nionata @tamargoadam @tamargoadam98