Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

fix: Use ULID instead of UUID #128

Merged
merged 5 commits into from
Aug 7, 2023
Merged

fix: Use ULID instead of UUID #128

merged 5 commits into from
Aug 7, 2023

Conversation

pueding
Copy link
Member

@pueding pueding commented Aug 7, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

With ULID(Universal Lexicographically Sortable Identifier), we can create an ID with a timestamp so created_at is unnecessary. Especially, autoscaling history could be generated a lot and it would take up much storage. With ULID, the storage would be saved.

Which issue/s this PR fixes

#80

How Has This Been Tested?

  • unit tests in core/data-layer/src/data_layer.rs

Checklist:

@pueding pueding linked an issue Aug 7, 2023 that may be closed by this pull request
Use ULID instead of UUID #80
Closed
@pueding pueding merged commit 64e8dc4 into main Aug 7, 2023
@pueding pueding deleted the 80-use-ulid-instead-of-uuid branch August 7, 2023 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ULID instead of UUID
1 participant
@pueding