Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive basic traits on enums #10

Merged
merged 1 commit into from
Aug 5, 2018
Merged

Conversation

kvark
Copy link
Contributor

@kvark kvark commented Aug 3, 2018

No description provided.

bors bot added a commit to gfx-rs/gfx that referenced this pull request Aug 4, 2018
2292: Metal command recording option r=grovesNL a=kvark

Based on #2288
Implements first bits of #2236

Allows the client to control the recording option without re-building gfx-rs.
Also hides the remote sink behind a feature. We can't CI-test it until SSheldon/rust-dispatch#10 is accepted and published.

PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot added a commit to gfx-rs/gfx that referenced this pull request Aug 4, 2018
2292: Metal command recording option r=grovesNL a=kvark

Based on #2288
Implements first bits of #2236

Allows the client to control the recording option without re-building gfx-rs.
Also hides the remote sink behind a feature. We can't CI-test it until SSheldon/rust-dispatch#10 is accepted and published.

PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <[email protected]>
@SSheldon SSheldon merged commit 154e506 into SSheldon:master Aug 5, 2018
@SSheldon
Copy link
Owner

SSheldon commented Aug 5, 2018

Thanks!

@kvark kvark deleted the enum-derive branch August 6, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants