Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial FreeBSD build fixes #7907

Closed
wants to merge 2 commits into from
Closed

Trivial FreeBSD build fixes #7907

wants to merge 2 commits into from

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented Apr 1, 2025

No description provided.

@alexey-tikhonov alexey-tikhonov self-requested a review April 1, 2025 11:31
@alexey-tikhonov alexey-tikhonov self-assigned this Apr 1, 2025
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Apr 1, 2025
@andreboscatto andreboscatto requested a review from thalman April 1, 2025 12:35
thalman
thalman approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the effort

@alexey-tikhonov alexey-tikhonov requested a review from thalman April 7, 2025 14:48
@alexey-tikhonov
Copy link
Member

@thalman, please take the look at the updated version.

@alexey-tikhonov
Copy link
Member

@arrowd, could you please rebase?

arrowd added 2 commits April 9, 2025 17:31
@arrowd
Fix build on FreeBSD by including sys/socket.h
ebc1daf 
According to POSIX standard [1] it is sys/socket.h header that defines
AF_UNSPEC and SOCK_STREAM.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html
@arrowd
Use cli_creds_get_*() helpers wherever possible
ad95bae 
While there, fix typo in the definition of cli_creds_get_gid()
@alexey-tikhonov alexey-tikhonov added Waiting for review coverity Trigger a coverity scan labels Apr 9, 2025
@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Apr 10, 2025
@alexey-tikhonov
Copy link
Member

Pushed PR: #7907

  • master
    • dfceb68 - Use cli_creds_get_*() helpers wherever possible
    • dbe8200 - Fix build on FreeBSD by including sys/socket.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalman thalman thalman approved these changes

@alexey-tikhonov alexey-tikhonov alexey-tikhonov approved these changes

Assignees

@thalman thalman

@alexey-tikhonov alexey-tikhonov

Labels
coverity Trigger a coverity scan no-backport This should go to target branch only. Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arrowd @alexey-tikhonov @thalman