-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete 'lib/sifp' #7812
Closed
Closed
Delete 'lib/sifp' #7812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
force-pushed
the
del-libsifp
branch
from
January 24, 2025 19:15
4ff6a76
to
53122fb
Compare
:relnote:Previously deprecated `--with-libsifp` configure option and 'sss_simpleifp' library were removed.
alexey-tikhonov
force-pushed
the
del-libsifp
branch
from
January 25, 2025 09:49
53122fb
to
248d1e7
Compare
alexey-tikhonov
force-pushed
the
del-libsifp
branch
from
January 25, 2025 10:24
248d1e7
to
880cac5
Compare
andreboscatto
requested review from
thalman and
ikerexxe
and removed request for
pbrezina
January 28, 2025 13:34
ikerexxe
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Wow! How many configurations we have been able to remove with a couple of changes that seemed so small.
thalman
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove C9S from supported platforms list.