Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to the data module #51

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Add tests to the data module #51

merged 3 commits into from
Feb 18, 2025

Conversation

MGaetan89
Copy link
Member

Changes made:

  • Switch to using classes from kotlin-test instead of jUnit.
  • Add tests to the classes in the remote package.
  • Move existing serializer tests to the serializer package.

@MGaetan89 MGaetan89 self-assigned this Sep 6, 2024
@MGaetan89
Copy link
Member Author

@Loic-Dumas @StaehliJ should we merge this?
It only adds tests to the data package, and simplify some code. But there is no change in logic.

@MGaetan89 MGaetan89 force-pushed the add_data_test branch 4 times, most recently from d01555e to 784b024 Compare January 21, 2025 12:10
@MGaetan89 MGaetan89 added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 04e5bb4 Feb 18, 2025
6 checks passed
@MGaetan89 MGaetan89 deleted the add_data_test branch February 18, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

@Loic-Dumas Loic-Dumas Awaiting requested review from Loic-Dumas

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @StaehliJ