Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on CI #94

Merged
merged 15 commits into from
Jun 29, 2022
Merged

Fix tests on CI #94

merged 15 commits into from
Jun 29, 2022

Conversation

emirkmo
Copy link
Member

@emirkmo emirkmo commented Jun 28, 2022

Tests_passing_locally

Turns out tests were not properly running on CI, just locally. Now they seem to pass except for the odd HTTP error from Alerce, (seems random), which is likely happening due to us hitting their server too often.

However tests pass locally (as they were before), and now have been modified to pass on CI.

I thought this was going to be a simple change.. I should have done this on a branch.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #94 (c1099ea) into master (3d942dd) will increase coverage by 29.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #94       +/-   ##
===========================================
+ Coverage   24.14%   53.50%   +29.36%     
===========================================
  Files          35       35               
  Lines        3082     3121       +39     
===========================================
+ Hits          744     1670      +926     
+ Misses       2338     1451      -887     
Impacted Files Coverage Δ
flows/fileio.py 78.01% <ø> (+36.56%) ⬆️
flows/tns.py 30.10% <0.00%> (+9.67%) ⬆️
flows/instruments/instruments.py 57.34% <0.00%> (+11.01%) ⬆️
flows/image.py 60.20% <0.00%> (+11.22%) ⬆️
flows/catalogs.py 33.45% <0.00%> (+20.72%) ⬆️
flows/result_model.py 48.14% <0.00%> (+25.92%) ⬆️
flows/filters.py 80.00% <0.00%> (+30.00%) ⬆️
flows/target.py 97.50% <0.00%> (+35.00%) ⬆️
flows/coordinatematch/wcs.py 61.38% <0.00%> (+36.63%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d942dd...c1099ea. Read the comment docs.

@emirkmo emirkmo merged commit 8684469 into master Jun 29, 2022
emirkmo added a commit that referenced this pull request Jun 29, 2022
Merge pull request #94 from SNflows/devel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant