-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on CI #94
Merged
Fix tests on CI #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
===========================================
+ Coverage 24.14% 53.50% +29.36%
===========================================
Files 35 35
Lines 3082 3121 +39
===========================================
+ Hits 744 1670 +926
+ Misses 2338 1451 -887
Continue to review full report at Codecov.
|
emirkmo
added a commit
that referenced
this pull request
Jun 29, 2022
Merge pull request #94 from SNflows/devel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out tests were not properly running on CI, just locally. Now they seem to pass except for the odd HTTP error from Alerce, (seems random), which is likely happening due to us hitting their server too often.
However tests pass locally (as they were before), and now have been modified to pass on CI.
I thought this was going to be a simple change.. I should have done this on a branch.