Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests failing on PRs from forks #46

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Fix CI tests failing on PRs from forks #46

merged 1 commit into from
Feb 15, 2022

Conversation

emirkmo
Copy link
Member

@emirkmo emirkmo commented Feb 15, 2022

Change tests.yml to use pull_request_target, as that it supposed to run the workflow against the base repo instead of against the fork in a safe way.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

Fixes #33

@emirkmo emirkmo changed the title change to pull_request_target Fix CI tests failing on PRs from forks Feb 15, 2022
@emirkmo emirkmo merged commit 975436b into devel Feb 15, 2022
@emirkmo
Copy link
Member Author

emirkmo commented Feb 15, 2022

This should work, but if it doesn't, we can revert.

@emirkmo emirkmo deleted the Fix_remote_tests branch August 9, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on PRs from forked repos
1 participant