Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of issues #150

Merged
merged 20 commits into from
Feb 10, 2023
Merged

Fix a bunch of issues #150

merged 20 commits into from
Feb 10, 2023

Conversation

emirkmo
Copy link
Member

@emirkmo emirkmo commented Feb 8, 2023

Resolves #140, resolves #139, resolves #132, resolves #126, resolves #114, resolves #99, resolves #101, resolves #98, resolves #97, resolves #96, resolves #53, resolves #141, resolves #142, resolves #144, resolves #145, resolves #146, resolves #147

  • Refactor API out of flows code and to use tendrils instead.
  • Fix SDSS query bug
  • Ensure alerce API working via tendrils integration.
  • Add test for new instruments being added to INSTRUMENTS
  • Add Guessing of flows filter from header for use in instrument and load image classes. filters.py. add functions match_header_to_filter match_filter_to_flows.
  • add local site generation from astropy, user input, and from flows.
  • Ensure all tests, including catalog and DB tests, ZTF/Alerce, TNS are passing.
  • Add environment variables for missing configs such as casjobs or for the AU DB service account
  • ...
  • See linked issues and commit messages for more details.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 53.68% // Head: 53.62% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (7f89e4e) compared to base (6af9c79).
Patch coverage: 47.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #150      +/-   ##
==========================================
- Coverage   53.68%   53.62%   -0.06%     
==========================================
  Files          35       35              
  Lines        3111     3103       -8     
==========================================
- Hits         1670     1664       -6     
+ Misses       1441     1439       -2     
Impacted Files Coverage Δ
flows/instruments/__init__.py 100.00% <ø> (ø)
flows/run_imagematch.py 0.00% <0.00%> (ø)
flows/visibility.py 17.33% <20.00%> (ø)
flows/tns.py 30.10% <30.10%> (ø)
flows/photometry.py 81.90% <33.33%> (ø)
flows/catalogs.py 33.45% <60.00%> (ø)
flows/image.py 60.20% <80.00%> (ø)
flows/instruments/instruments.py 56.79% <90.90%> (-0.39%) ⬇️
flows/aadc_db.py 100.00% <100.00%> (ø)
flows/fileio.py 88.15% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@emirkmo emirkmo merged commit cc4ff86 into devel Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment