Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block on select() in rtpstream_playrtptask #690

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

acumeeple
Copy link
Contributor

We are supposed to be calling this function repeatedly in a loop running every 20ms or so.
Blocking for 10ms on select() in here destroys packet send timing.
This should fix issue #665.

We are supposed to be calling this function repeatedly in a loop running every 20ms or so. Blocking here will destroy packet send timing.
@orgads
Copy link
Contributor

orgads commented Mar 1, 2024

@wdoekes Can you please approve?

@wdoekes
Copy link
Member

wdoekes commented Mar 1, 2024

Check your invites ;)

@orgads
Copy link
Contributor

orgads commented Mar 1, 2024

Thanks! :)

@orgads orgads merged commit 2e74b74 into SIPp:master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants