Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build to proceed if gtest is missing #638

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

rkday
Copy link
Contributor

@rkday rkday commented May 19, 2023

Fixes #637 and #626 .

If gtest is missing, you can now build the sipp binary. sipp_unittest still depends on gtest, and attempts to build that with it missing will fail with:

/home/rkd/src/sipp/src/sipp_unittest.cpp:22:10: fatal error: gtest/gtest.h: No such file or directory
   22 | #include "gtest/gtest.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.

@rkday rkday merged commit 1126a8b into master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building sipp 3.7.0
1 participant