Fix a segmentation fault in 'call.cpp:2369: createAuthHeader' #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Detailed feature documentation available upon request]
Gateway RTP/SRTP bit pattern testing support (SIPP-RTPCHECK-3.6) This may require some addiitonal additions, like: - more documentation - checks whether this can be disabled/enabled properly and TLS is still optional Thanks Jeannot Langlois (@jeannotlanglois) for the big effort.
…headers when performing lookups. (SIPp#465) * Extract short_header logic into function * Handle mixed header compactness * Handle cases ordering of headers matters * Minor cleanup * Tweak get_compact_header_name Issue SIPp#465, by Karn Saheb Karn (@Karn). (Thanks for the fixes and the included test case.)
… sction of a message
|
So it crashes on In that case the fix is not to calculate a different (wrong) hash, but do something else (return error?). |
yes, it crashes because it will call "createAuthHeaderMD5" (auth.cpp:242) with "method" being a null pointer, whitch leads to the crash in "strlen(method)" (auth.cpp:281)
Ah, yes - true! I've updated the pull request accordingly. It returns an error in the calling function "createAuthHeader" (auth.cpp:145). |
|
Closed by 010ee75. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SegFault only happens if the SIPp reference to the authentication header (in our case [field2], see the attached 'fail.xml') is used (in the example 'fail.xml': echo [field2]) after or in the receive section of the REGISTER message which actually sends the authentication header. In this case "getMethod" returns 0x0 (see 'gdb.txt', also attached).
It was introduced by commit 6dd80fe by using the function 'src->getMethod()' instead of the variable 'method'.
fix_info.tar.gz