Increment nonce count and get auth method from message being sent. #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nonce count changes are based on the patch described here: https://sipp-users.narkive.com/6Gl681EP/patch-to-correctly-increment-nc-in-authorization-header The old way of getting the auth method from the CSeq of the last header would fail if the previous message sent was a different method than the current one. It seems simple and safe to just use the method of the message being sent.
|
Hello. At your convenience, please let me know if you'd like any additional information about these changes. Thanks very much. |
|
The changes look sane, so I think this is good to go. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I'm trying to address two digest authentication issues I've encountered while executing several of my scenarios.
1.) SIPp currently doesn't support incrementing the nonce count to keep an ongoing authenticated call alive without being re-challenged on every request. In several of my scenarios, this was resulting in undesired challenges. The nonce count changes are based on an old patch I found here:
https://sipp-users.narkive.com/6Gl681EP/patch-to-correctly-increment-nc-in-authorization-header
2.) In some of my scenarios which mix different SIP request methods, I was having some unexpected authentication failures. I tracked it down to the method being used to generate the auth hashes not matching the method of the message being sent.
The old way of getting the auth method from the CSeq of the last header would fail if the previous message sent was a different method than the current message being sent. It seems simple and safe to just use the method of the message being sent when generating the auth hashes.
Thanks for the consideration.