Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Install scikit-learn instead of deprecated sklearn #99

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Dec 15, 2022

Motivation

× python setup.py egg_info did not run successfully.
[47](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:48)
  │ exit code: 1
[48](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:49)
  ╰─> [18 lines of output]
[49](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:50)
      The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
[50](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:51)
      rather than 'sklearn' for pip commands.
[51](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:52)
      
[52](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:53)
      Here is how to fix this error in the main use cases:
[53](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:54)
      - use 'pip install scikit-learn' rather than 'pip install sklearn'
[54](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:55)
      - replace 'sklearn' by 'scikit-learn' in your pip requirements files
[55](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:56)
        (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...)
[56](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:57)
      - if the 'sklearn' package is used by one of your dependencies,
[57](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:58)
        it would be great if you take some time to track which package uses
[58](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:59)
        'sklearn' instead of 'scikit-learn' and report it to their issue tracker
[59](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:60)
      - as a last resort, set the environment variable
[60](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:61)
        SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error
[61](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:62)
      
[62](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:63)
      More information is available at
[63](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:64)
      https://github.com/scikit-learn/sklearn-pypi-package
[64](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:65)
      
[65](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:66)
      If the previous advice does not cover your use case, feel free to report it at
[66](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:67)
      https://github.com/scikit-learn/sklearn-pypi-package/issues/new
[67](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:68)
      [end of output]
[68](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:69)
  
[69](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:70)
  note: This error originates from a subprocess, and is likely not a problem with pip.
[70](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:71)
error: metadata-generation-failed
[71](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:72)

[72](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:73)
× Encountered error while generating package metadata.
[73](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:74)
╰─> See above for output.
[74](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:75)

[75](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:76)
note: This is an issue with the package mentioned above, not pip.
[76](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:77)
hint: See above for details.
[77](https://github.com/SIAnalytics/siatune/actions/runs/3702550299/jobs/6272960697#step:7:78)
Error: Process completed with exit code 1.

@KKIEEK KKIEEK requested a review from nijkah December 15, 2022 09:10
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@16c2cd1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage        ?   76.21%           
=======================================
  Files           ?       59           
  Lines           ?     1455           
  Branches        ?      199           
=======================================
  Hits            ?     1109           
  Misses          ?      276           
  Partials        ?       70           
Flag Coverage Δ
unittests 76.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KKIEEK KKIEEK changed the title Fix requirements for build workflow Fix requirements Dec 15, 2022
@nijkah nijkah changed the title Fix requirements [Fix] sklearn depreated, install scikit-learn Dec 15, 2022
@KKIEEK KKIEEK changed the title [Fix] sklearn depreated, install scikit-learn [Fix] sklearn depreated, install scikit-learn Dec 15, 2022
@KKIEEK KKIEEK changed the title [Fix] sklearn depreated, install scikit-learn [Fix] Install scikit-learn instead of sklearn Dec 15, 2022
@KKIEEK KKIEEK changed the title [Fix] Install scikit-learn instead of sklearn [Fix] Install scikit-learn instead of deprecated sklearn Dec 15, 2022
@KKIEEK KKIEEK merged commit badb02a into main Dec 15, 2022
@KKIEEK KKIEEK deleted the fix/requirements branch December 15, 2022 09:26
@nijkah nijkah mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants