Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix CI check for Draft PR #89

Merged
merged 8 commits into from
Dec 1, 2022
Merged

[Fix] Fix CI check for Draft PR #89

merged 8 commits into from
Dec 1, 2022

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Dec 1, 2022

https://github.com/orgs/community/discussions/25722

Skipping CI is recognized as a success.
So when skipping CI, make failure instead.

@yhna940 yhna940 marked this pull request as ready for review December 1, 2022 08:06
@yhna940 yhna940 marked this pull request as draft December 1, 2022 08:07
@yhna940 yhna940 marked this pull request as ready for review December 1, 2022 08:20
@yhna940 yhna940 marked this pull request as draft December 1, 2022 08:22
@yhna940 yhna940 marked this pull request as ready for review December 1, 2022 08:25
@yhna940 yhna940 force-pushed the hotfix/ci-updatecs branch from d3de873 to 2aa6f73 Compare December 1, 2022 08:28
@yhna940 yhna940 marked this pull request as draft December 1, 2022 08:29
@yhna940 yhna940 marked this pull request as ready for review December 1, 2022 08:34
@yhna940 yhna940 requested review from nijkah and KKIEEK December 1, 2022 08:37
@yhna940 yhna940 added bug Something isn't working ci Related with CI labels Dec 1, 2022
@yhna940 yhna940 self-assigned this Dec 1, 2022
@nijkah
Copy link
Member

nijkah commented Dec 1, 2022

@yhna940 https://stackoverflow.com/a/68349262
How about using this?

@yhna940 yhna940 marked this pull request as draft December 1, 2022 08:41
This reverts commit aa09fcf.
@yhna940
Copy link
Contributor Author

yhna940 commented Dec 1, 2022

@yhna940 https://stackoverflow.com/a/68349262
How about using this?

Not working for me :(

@yhna940 yhna940 marked this pull request as ready for review December 1, 2022 08:44
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@84e0c83). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage        ?   76.09%           
=======================================
  Files           ?       59           
  Lines           ?     1456           
  Branches        ?      199           
=======================================
  Hits            ?     1108           
  Misses          ?      278           
  Partials        ?       70           
Flag Coverage Δ
unittests 76.09% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nijkah nijkah changed the title [Fix] draft pr [Fix] Fix CI check for Draft PR Dec 1, 2022
@yhna940 yhna940 merged commit 6549c8d into main Dec 1, 2022
@yhna940 yhna940 deleted the hotfix/ci-updatecs branch December 1, 2022 12:29
@nijkah nijkah mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Related with CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants