Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix choice space to handle case where no alias is set #79

Merged
merged 8 commits into from
Dec 1, 2022

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Nov 30, 2022

Changed the sampling class so that data is included in the container even if there is no alias.

@yhna940 yhna940 added the bug Something isn't working label Nov 30, 2022
@yhna940 yhna940 requested review from nijkah and KKIEEK November 30, 2022 07:44
@yhna940 yhna940 self-assigned this Nov 30, 2022
@yhna940 yhna940 requested a review from KKIEEK December 1, 2022 00:49
@nijkah nijkah changed the title [Fix] choice space [Fix] Fix choice space to handle case where no alias is set Dec 1, 2022
@yhna940 yhna940 force-pushed the hotflix/categorical-choice branch from 221bd9c to 88066b0 Compare December 1, 2022 06:07
@yhna940 yhna940 requested a review from nijkah December 1, 2022 06:09
@yhna940 yhna940 marked this pull request as draft December 1, 2022 09:02
@yhna940 yhna940 marked this pull request as ready for review December 1, 2022 09:03
@yhna940 yhna940 merged commit 4d0676a into main Dec 1, 2022
@yhna940 yhna940 deleted the hotflix/categorical-choice branch December 1, 2022 09:13
@nijkah nijkah mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants