Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune configs #70

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Prune configs #70

merged 6 commits into from
Nov 30, 2022

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Oct 7, 2022 •
edited
Loading

TODO

  • Fix test code
  • Update ignore-words-list

@KKIEEK KKIEEK requested a review from nijkah October 7, 2022 16:38
@KKIEEK KKIEEK changed the title Del/configs Prune unnecessary configs Oct 7, 2022
@KKIEEK KKIEEK requested a review from yhna940 November 23, 2022 03:53
@yhna940 yhna940 marked this pull request as ready for review November 23, 2022 04:05
yhna940
yhna940 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@yhna940 yhna940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhna940 yhna940 added duplicate This issue or pull request already exists enhancement New feature or request and removed duplicate This issue or pull request already exists labels Nov 23, 2022
@yhna940 yhna940 linked an issue Nov 23, 2022 that may be closed by this pull request
[Add] support MMEngine cfg format #71
Closed
@KKIEEK KKIEEK changed the title Prune unnecessary configs Prune configs Nov 30, 2022
@KKIEEK KKIEEK merged commit 647761f into main Nov 30, 2022
@KKIEEK KKIEEK deleted the del/configs branch November 30, 2022 17:04
@nijkah nijkah mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijkah nijkah nijkah approved these changes

@yhna940 yhna940 yhna940 approved these changes

Assignees

@KKIEEK KKIEEK

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add] support MMEngine cfg format
3 participants
@KKIEEK @nijkah @yhna940