Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support HyperOpt and FLAML search algorithms #60

Merged
merged 9 commits into from
Sep 6, 2022
Merged

[Feature] Support HyperOpt and FLAML search algorithms #60

merged 9 commits into from
Sep 6, 2022

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Sep 5, 2022 •
edited by nijkah
Loading

Closes #18

  • Support HyperOpt
  • Support FLAML
  • Add Test Code
  • TODO) Support AxSearch

@github-actions
Copy link

github-actions bot commented Sep 5, 2022 •
edited
Loading

Coverage report

The coverage rate is 79.61%

The branch rate is 59.34%

95% of new lines are covered.

Diff Coverage details (click to unfold)

mmtune/ray/searchers/hyperopt.py

100.0% of new lines are covered

mmtune/ray/searchers/init.py

100.0% of new lines are covered

mmtune/ray/searchers/nevergrad.py

100.0% of new lines are covered

mmtune/utils/container.py

66.66666666666667% of new lines are covered

mmtune/ray/searchers/flaml.py

100.0% of new lines are covered

@KKIEEK KKIEEK marked this pull request as ready for review September 5, 2022 09:50
yhna940
yhna940 reviewed Sep 5, 2022
View reviewed changes
mmtune/utils/container.py
if other.__class__ is self.__class__:
return self.data == other.data
raise NotImplementedError
def __hash__(self) -> int:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add the hashing function?

@KKIEEK KKIEEK requested review from yhna940 and nijkah September 6, 2022 05:05
@nijkah nijkah changed the title Support some search algorithms [Feature] Support HyperOpt and FLAML search algorithms Sep 6, 2022
nijkah
nijkah approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@nijkah nijkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KKIEEK KKIEEK merged commit 8d19107 into master Sep 6, 2022
@nijkah nijkah deleted the feat/search_algo branch September 8, 2022 06:41
@nijkah nijkah mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijkah nijkah nijkah approved these changes

@yhna940 yhna940 yhna940 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Evince] Search Algorithm Support
3 participants
@KKIEEK @nijkah @yhna940