Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Reporting error when using DDP #57

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[Fix] Reporting error when using DDP #57

merged 1 commit into from
Sep 6, 2022

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Jul 4, 2022

This request is prepared in case the log buffer status is different for each rank in the ddp environment.

Compared to the original one, this hook logs every time without checking log_buffer.ready when they called.

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Coverage report

The coverage rate is 79.42%

The branch rate is 58.76%

15% of new lines are covered.

Diff Coverage details (click to unfold)

mmtune/mm/hooks/reporter.py

15.789473684210535% of new lines are covered

Copy link
Member

@nijkah nijkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll debug this. Please wait for me.

@nijkah nijkah changed the title Fix ddp reporting err [Fix] Reporting error when using DDP Sep 6, 2022
@yhna940 yhna940 merged commit e5df2b8 into master Sep 6, 2022
@yhna940 yhna940 deleted the fix/report-bug branch September 6, 2022 05:18
@nijkah nijkah mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants