Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ray logger callbacks #31

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Support ray logger callbacks #31

merged 5 commits into from
Jun 24, 2022

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented May 26, 2022

No description provided.

@KKIEEK KKIEEK requested review from yhna940 and nijkah May 26, 2022 07:23
yhna940
yhna940 previously approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@yhna940 yhna940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nijkah
nijkah requested changes May 30, 2022
View reviewed changes
Copy link
Member

@nijkah nijkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring is required to clarify the difference compared to the original MLflowLoggerCallback.

nijkah
nijkah requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@nijkah nijkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the final test

@KKIEEK KKIEEK marked this pull request as draft June 22, 2022 07:09
@KKIEEK KKIEEK marked this pull request as ready for review June 23, 2022 08:07
nijkah
nijkah reviewed Jun 23, 2022
View reviewed changes
mmtune/ray/callbacks/mlflow.py


@CALLBACKS.register_module()
class MLflowLoggerCallback(_MLflowLoggerCallback):
Copy link
Member

@nijkah nijkah Jun 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change compared to the original one should be specified as docstring.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.ray.io/en/releases-1.9.1/_modules/ray/tune/integration/mlflow.html#MLflowLoggerCallback

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

Coverage report

The coverage rate is 82.39999999999999%

The branch rate is 60.92999999999999%

100% of new lines are covered.

@nijkah
Copy link
Member

nijkah commented Jun 24, 2022 •
edited
Loading

@KKIEEK I added docstring to some methods. Please check.

@KKIEEK KKIEEK merged commit bb04144 into master Jun 24, 2022
@nijkah nijkah deleted the feat/callbacks branch June 24, 2022 08:09
@KKIEEK KKIEEK restored the feat/callbacks branch June 24, 2022 08:53
@KKIEEK KKIEEK deleted the feat/callbacks branch June 24, 2022 09:12
@nijkah nijkah mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijkah nijkah nijkah approved these changes

@yhna940 yhna940 yhna940 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKIEEK @nijkah @yhna940