Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for importing custom modules #126

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Dec 27, 2022

Motivation

Related to #122

Modification

I added function register_all_modules, which is modified from mmdet repo.

@KKIEEK KKIEEK requested review from nijkah and yhna940 December 27, 2022 09:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@68d479d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage        ?   61.42%           
=======================================
  Files           ?       59           
  Lines           ?     1970           
  Branches        ?      316           
=======================================
  Hits            ?     1210           
  Misses          ?      652           
  Partials        ?      108           
Flag Coverage Δ
unittests 61.42% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KKIEEK KKIEEK changed the title Add support for importing custom modules [Feature] Add support for importing custom modules Dec 27, 2022
Copy link
Contributor

@yhna940 yhna940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@KKIEEK KKIEEK merged commit 8deda8b into main Dec 29, 2022
@KKIEEK KKIEEK deleted the feat/custom-imports branch December 29, 2022 06:21
@yhna940 yhna940 mentioned this pull request Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants