Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support MIM trainable #125

Merged
merged 50 commits into from
Jan 7, 2023
Merged

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Dec 27, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Supports the mim task.

Modification

The main changes are as follows:

  1. Addition of mim task processor (implemented based on entry point)
  2. support for arguments not parsed in context

The minor changes are as follows:

  1. Removal of ckpt hook and integration with reporter hook (interface change in ray 2.x)
  2. Removal of ray train ddp trainer

The reason for the implementation of the second minor change is as follows:

  1. Removal of dependency on ray train
  2. Determined that the usability of the cfg table is decreased with the display of train loop config
  3. Thought that ray train was too large for the desired function
  4. Ray ddp trainer changed paths voluntarily
  5. Need for sharing metrics between workers."

Checklist

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  • The documentation has been modified accordingly, like docstring or example tutorials.

@yhna940 yhna940 requested a review from KKIEEK December 27, 2022 07:06
@KKIEEK
Copy link
Contributor

KKIEEK commented Dec 27, 2022

Based on the current implementation, I don't think it's necessary for BaseTask to have a parse_args interface. What do you think?

@KKIEEK KKIEEK linked an issue Dec 29, 2022 that may be closed by this pull request
@yhna940 yhna940 requested a review from KKIEEK December 29, 2022 09:33
@yhna940 yhna940 marked this pull request as ready for review January 6, 2023 08:10
yhna940 and others added 2 commits January 7, 2023 09:53
Co-authored-by: Hakjin Lee <[email protected]>
Signed-off-by: YH <[email protected]>
Co-authored-by: Junhwa Song <[email protected]>
Signed-off-by: YH <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@7443863). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage        ?   61.71%           
=======================================
  Files           ?       63           
  Lines           ?     1959           
  Branches        ?      312           
=======================================
  Hits            ?     1209           
  Misses          ?      646           
  Partials        ?      104           
Flag Coverage Δ
unittests 61.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yhna940 yhna940 changed the title [WIP] Support irresponsible trainable [Enhance] Support MIM trainable Jan 7, 2023
@yhna940 yhna940 requested review from KKIEEK and nijkah January 7, 2023 04:54
Copy link
Contributor

@KKIEEK KKIEEK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

@yhna940 yhna940 merged commit 13cf8db into main Jan 7, 2023
@yhna940 yhna940 deleted the feature/irresponsible-trainable branch January 7, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants