-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for Optuna #111
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage ? 72.79%
=======================================
Files ? 59
Lines ? 1632
Branches ? 235
=======================================
Hits ? 1188
Misses ? 345
Partials ? 99
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💡
Modification
I added config for
Optuna
. Please refer to this docs.Limitation
However, I think we have overridden
__eq__
special method forImmutableContainer
before, so this warning is probably not a critical problem.Refer to optuna's code and ours for details.
Result
MedianStoppingRule w/ Optuna