Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Change the directory hierarchy #110

Merged
merged 5 commits into from
Dec 20, 2022

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Dec 20, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@KKIEEK KKIEEK changed the title Change the directory structure Change the directory hierarchy Dec 20, 2022
@KKIEEK KKIEEK requested review from nijkah and yhna940 and removed request for nijkah December 20, 2022 02:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@58bf811). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 8441977 differs from pull request most recent head d61bb5b. Consider uploading reports for the commit d61bb5b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage        ?   72.79%           
=======================================
  Files           ?       59           
  Lines           ?     1632           
  Branches        ?      235           
=======================================
  Hits            ?     1188           
  Misses          ?      345           
  Partials        ?       99           
Flag Coverage Δ
unittests 72.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KKIEEK KKIEEK force-pushed the refactor/hierarchy branch from d61bb5b to 62c85f5 Compare December 20, 2022 02:53
Copy link
Contributor

@yhna940 yhna940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KKIEEK KKIEEK changed the title Change the directory hierarchy [Refactor] Change the directory hierarchy Dec 20, 2022
@KKIEEK KKIEEK merged commit 10965e3 into SIAnalytics:main Dec 20, 2022
@KKIEEK KKIEEK deleted the refactor/hierarchy branch December 20, 2022 03:32
@yhna940 yhna940 mentioned this pull request Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants